Skip to content

Use Cython INFINITY instead of float('inf') - #1263

Merged
Joao-Dionisio merged 3 commits into
scipopt:masterfrom
Zeroto521:infinity-replace
Oct 10, 2026
Merged

Joao-Dionisio merged 3 commits into
scipopt:masterfrom
Zeroto521:infinity-replace

Conversation

@Zeroto521

@Zeroto521 Zeroto521 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Model.addCons dispatches on the expression degree; the "general nonlinear" fallback compared deg against Python's float('inf'). Use Cython's INFINITY instead, consistent with expr.pxi.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 16:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Zeroto521 Zeroto521 changed the title REF: use Cython INFINITY instead of float('inf') Use Cython INFINITY instead of float('inf') Oct 9, 2026
@Zeroto521 Zeroto521 changed the title Use Cython INFINITY instead of float('inf') Use Cython INFINITY instead of float('inf') Oct 9, 2026

@Joao-Dionisio Joao-Dionisio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you as always, @Zeroto521 !

@Joao-Dionisio
Joao-Dionisio added this pull request to the merge queue Oct 10, 2026
Merged via the queue into scipopt:master with commit 18228d4 Oct 10, 2026
7 checks passed
@Zeroto521
Zeroto521 deleted the infinity-replace branch October 11, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants