Repository navigation
Annotate more straightforward APIs in the stubs - #1271
Open
jonathanberthias wants to merge 24 commits into
Open
jonathanberthias wants to merge 24 commits into
jonathanberthias wants to merge 24 commits into
Conversation
Member
|
Awesome work @jonathanberthias , thank you! I went through the changes (both myself and with an agent), and all seem to correct! The stub test doesn't detect that new incomplete stubs are added, correct? Could we change this in a follow up PR? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite a few methods and attributes still use
Incomplete, even where the implementation makes their types fairly clear.Following #1220, this is another batch of straightforward annotations: mostly getters,
ModelandLPmethods, file paths, and matrix results. I also filled in concrete default values where possible.Deprecated APIs now use
@deprecated, and mypy checks for deprecated usage and unused ignores.The commits are split by topic, so reviewing them individually might be easier.
Part of #1072