[ESSNMX] Fix weekly test for NMX - #684
Merged
Merged
Conversation
github-actions
Bot
changed the title
Comment on lines
+29
to
+37
| try: | ||
| # The bitshuffle plugin needs to be imported at least once in the session | ||
| # so that h5py can use the plugin. | ||
| import bitshuffle.h5 # noqa: F401 | ||
| except ImportError: | ||
| pytest.skip( | ||
| allow_module_level=True, | ||
| reason="File output regression test cannot be done without `bitshuffle.h5`.", | ||
| ) |
Member
There was a problem hiding this comment.
Why not pytest.importorskip?
Member
Author
There was a problem hiding this comment.
Yeah you're right...! I updated it.
SimonHeybrock
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was just because of the bitshuffle.h5 ...
I tested manually https://github.com/scipp/ess/actions/runs/30463403880
The other issue was that the plotting was done with interactive backend in the windows.
I just set the default backend to be
Aggfor NMX executable since it only dumps PNG files.It's already a known issue: scipp/plopp#516