Skip to content

feat(core): add an isolated evidence-only review harness - #592

Open
chent1996 wants to merge 2 commits into
refactor/coding-agentfrom
task/review-185447ffbfc8
Open

chent1996 wants to merge 2 commits into
refactor/coding-agentfrom
task/review-185447ffbfc8

Conversation

@chent1996

@chent1996 chent1996 commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add an optional evidence_review Agent type for analyzing supplied evidence without tools or ambient workspace resources. The context compiler and Agent factory enforce an empty tool set, fixed evidence-only instructions, and exclusion of MCP, memory, knowledge, skills, extensions, and workspace prompt files.

Current SiForge delivery reviews reuse the existing project Coding Agent; this optional harness is not the active delivery-review path. Companion SiCore provisioning validates the dedicated type before use. Existing Coding Agent source access remains unchanged.

Test Plan

  • Full test suite: 7083 passed, 2 skipped.
  • Runtime build and targeted compiler/factory/resource-loader/AgentBox tests passed.
  • Deployed Runtime/AgentBox regression: ordinary Coding Agent conversation and actual versioned source reads worked; release re-review and Workflow pass/fail gates completed.
  • Dedicated evidence-only model-envelope isolation verified in every deployment mode. Automated tests exercise resource exclusion; the latest live regression uses Coding Agent.
  • AgentBox code search: ripgrep is missing; the proposed image dependency change is not included.

Architecture Checklist

  • Deployment mode: full live dedicated-type verification in both LocalSpawner and K8sSpawner remains open.
  • Security model: no new shell execution path; the evidence-only type exposes no tools.
  • DB parity and new-tool registration: not applicable; this change adds neither a Portal database migration nor a tool.

General Checklist

  • Changes focus on the optional evidence-only harness.
  • Commit uses Conventional Commits.
  • No production dependency was added.

Related changes

Mount externally supplied source snapshots read-only per agent, gated by
the supplier ready marker. Introduce the generic coding type and keep
its tool capabilities aligned with SRE.

Use product-neutral runtime contracts, examples and documentation.

Tested: 486 targeted tests, runtime build and Portal type check.
@chent1996
chent1996 force-pushed the refactor/coding-agent branch from 6bc70a0 to abb6e79 Compare September 14, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant