馃┕ Fix spawning with directions being blocked by hostiles under safemode - #159
Open
tiennou wants to merge 2 commits into
Open
馃┕ Fix spawning with directions being blocked by hostiles under safemode#159tiennou wants to merge 2 commits into
tiennou wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported on Discord.
When a room is under safemode, newly born creeps can't actually spawn as the obstacle check there doesn't account for the safemode to be active (vs. the generic movement code, which does). This leads to a situation where, if you have a specific direction hardcoded, and an enemy creep stand there, spawning deadlocks until the obstacle clears even though technically they should be passable (per the safemode rules).
Fix the issue by extracting the more elaborate obstacle check helpers from movement into utils, and make use of that in _born-creep.js intent.
Note that the bulk of the spec was written by an LLM (really just prompted for "spec me this"), then some hefty guidance to have the helper extracted and wired in.