fix: handle scalar string groups in ranked-gene plots - #4330
Open
yingluosanqian wants to merge 1 commit into
Open
fix: handle scalar string groups in ranked-gene plots#4330yingluosanqian wants to merge 1 commit into
yingluosanqian wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4330 +/- ##
=======================================
Coverage 81.98% 81.99%
=======================================
Files 134 134
Lines 13235 13239 +4
=======================================
+ Hits 10851 10855 +4
Misses 2384 2384
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
groupsaccepts either a single string or a sequence of strings in the ranked-gene plotting APIs. However,sc.pl.rank_genes_groupsand the shared plotting path iterated a scalar string character by character.For example, passing
groups="Dendritic"attempted to look up the group"D"and raised an error instead of plotting"Dendritic".This PR normalizes scalar string group names to one-element lists before iteration, consistent with the existing behavior in
sc.pl.rank_genes_groups_violinandsc.get.rank_genes_groups_df.Tests