Skip to content

9/9 Use the terrain's height range when finding where a seed lands (changes terrain results) #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanth merged 1 commit into from
Sep 27, 2026
Merged

9/9 Use the terrain's height range when finding where a seed lands (changes terrain results) #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/characterization/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ Still open: the combined bottom + top + side view (`-g bts`) crashes with
`initCFDGText` in `vgraphics.py` fills the side-view template, which needs
six numbers, with only four. The `graphics_outputs` scenario pins this.

Also noticed, but not crashes: in `disperseSeed`, the terrain binary search
calls `elevationFromPixel(thePixelValue)` without `theGarden.maxElevation`,
so it uses the default 50 m while the first lookup uses the real maximum.
Also found, not a crash: in `disperseSeed`, the search for a seed's landing
point on terrain called `elevationFromPixel(thePixelValue)` without
`theGarden.maxElevation`, so it used the default 50 m range while the lookup
just before it used the terrain's real range. Fixed, together with the
direction of the pixel coordinates and the image's pixel range
(`getPixelRange`); the terrain recordings were re-recorded then.
Loading