[RBTSW-674] Create the node's /rosout publisher - #132
Open
AdamProchownik wants to merge 1 commit into
Open
Conversation
rcl_node_init() does not create the per-node /rosout publisher; the client library has to call rcl_logging_rosout_init_publisher_for_node() itself, as rclcpp and rclpy both do. Without it rcl_logging_rosout_output_handler() finds no publisher registered for the node's logger name and drops every record, so r2r logs only ever reach the console. rcl/logging_rosout.h was also not included by the bindgen wrapper, so the functions had no bindings at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rcl_node_init() does not create the per-node /rosout publisher; the client library has to call rcl_logging_rosout_init_publisher_for_node() itself, as rclcpp and rclpy both do. Without it rcl_logging_rosout_output_handler() finds no publisher registered for the node's logger name and drops every record, so r2r logs only ever reach the console.
rcl/logging_rosout.h was also not included by the bindgen wrapper, so the functions had no bindings at all.