Improve the documentation of Transform3D::perspective - #466
Merged
Conversation
kvark
approved these changes
Aug 21, 2020
kvark
left a comment
kvark
left a comment
Member
There was a problem hiding this comment.
And you want to publish this for one comment?
Contributor
Author
|
Yep, that and #464 which was contributed but not published yet. It's effortless to publish this kind of small non-breaking changes, we don't even have to update gecko. @bors-servo r=kvark |
Contributor
|
📌 Commit a8dfc57 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bit of confusion about the formulation of the perspective transform in #465. This clarifies things.