review: current portfolio for Greptile and CodeRabbit - #6
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR refines portfolio motion and typography behavior, adds visual alignment overrides, and corrects the Barba CDN package used by the 404 route.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking presentation issue caused by loading the new visual stylesheet only after JavaScript initialization. The motion and lifecycle changes retain explicit cleanup, but the new visual corrections are not part of initial static rendering and disappear entirely under the site's no-JavaScript fallback. Files Needing Attention: site-core.js, visual-fixes.css
|
| Filename | Overview |
|---|---|
| site-core.js | Adds runtime stylesheet injection; the stylesheet is consequently unavailable to initial and no-JavaScript rendering. |
| visual-fixes.css | Adds targeted case-layout and glyph-spacing overrides, but its delivery currently depends on JavaScript initialization. |
| gsap-layer.js | Replaces masked word/line splitting with persistent line wrappers and explicit tween cleanup. |
| motion-layer.js | Makes hover displacement configurable and adds non-tinting project-row movement with cleanup. |
| anime-layer.js | Adds a home-intro skip branch whose flag currently has no assignment, leaving existing behavior unchanged. |
| 404.html | Updates the Barba script source to the scoped core package. |
| README.md | Documents the revised transition, SplitText, cleanup, and project-evidence behavior. |
Sequence Diagram
sequenceDiagram
participant Browser
participant Core as site-core.js
participant CSS as visual-fixes.css
participant Barba as barba-layer.js
participant Motion as Page modules
Browser->>Core: Execute deferred script
Barba->>Core: initGlobal()
Core-->>CSS: Append stylesheet link
Barba->>Core: initPage(container, namespace)
Core->>Motion: Initialize GSAP, Motion, and Anime modules
CSS-->>Browser: Apply visual overrides asynchronously
Barba->>Core: clearPage() before navigation
Core->>Motion: Run page cleanups
Reviews (1): Last reviewed commit: "chore: copy live site-core onto linear r..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| if (!document.querySelector('link[href="/visual-fixes.css"]')) { | ||
| const fixSheet = document.createElement('link'); | ||
| fixSheet.rel = 'stylesheet'; | ||
| fixSheet.href = '/visual-fixes.css'; | ||
| document.head.appendChild(fixSheet); |
There was a problem hiding this comment.
Loading visual-fixes.css from initGlobal() excludes the new alignment and glyph-spacing rules from initial static rendering and the documented no-JavaScript fallback, while asynchronous loading can also restyle titles after first paint. Link this stylesheet directly from the route documents so these presentation rules are available before page initialization.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Review-only PR for Greptile and CodeRabbit.
PR #5 was closed because squash-merge history made
review/bot-audit→baseline/review-baseunmergeable.This replacement is a linear copy of the live site onto
baseline/review-base, so there are no merge conflicts.Do not merge this into
main. Livemainis already deployed. Do not open a PR ofbaseline/review-baseintomain.Add Greptile and CodeRabbit here and run reviews on motion, Barba handoffs, SplitText glyphs, CSS alignment, and Klar/Pakka/Metro routes.