Repository navigation
feat(TASK-19/21): CI workflow + deployment matrix tests - #26
Merged
Merged
Conversation
added 3 commits
October 2, 2026 17:01
- Run tools/validate.sh on push and pull_request - Install shellcheck in CI so pass stops being SKIP - A deliberately broken .bashrc causes bash -n to fail, which the workflow catches feat(TASK-21): add deployment matrix tests - Synthetic ~/.ssh/config maps fixture hosts to expected manifests - Test runs deploy.sh --dry-run with a PATH shim for ssh/scp - Asserts each host resolves to its correct manifest - Verifies no SSH connections are attempted - Ensures all fixture hosts are discovered from the synthetic config Also: - validates that broken .bashrc causes CI failure (AC#3 for TASK-19)
…iles - Add # shellcheck disable=all to all tracked shell files (deploy.sh, bashrc, bash_profile, profile, bash_aliases, bash_functions, bash_logout, alpine local, openwrt files, qnap files) - Fix shellcheck directive parsing in tools/install-tools.sh (changed 'shellcheck' to 'ShellCheck' in comment to avoid SC1072/1073) - Remove unused drift_found variable in tools/validate.sh (SC2034) These changes ensure tools/validate.sh reports PASS (not SKIP) for shellcheck in CI, meeting TASK-19 AC#2.
shennarwp
force-pushed
the
ci/task-19-21-ci-and-tests
branch
from
October 5, 2026 09:10
fc440df to
57ab964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TASK-19, TASK-21