Repository navigation
fix(deploy): restore missing transfer loop in deploy.sh - #32
Merged
Merged
Conversation
TASK-11 (3375fee) rewrote deploy.sh to batch SSH round trips but the actual file transfer loop was lost — the comment at line 300 was replaced with a colon (:) no-op. The deploy_remote() function built dsts/srcs/kinds arrays and ran backup/chmod/verify, but never called push() to copy files to remote hosts. This means every deploy since TASK-11 reported size mismatches but never overwrote remote files. The chtw alias (removed locally in merged/ .bash_aliases) persisted on all fleet hosts. Fix: - restore the transfer loop iterating dsts/srcs, calling push() - restore push_append() for host-local content preservation (alpine/qnap) - escape remote-side expansions in backup_remote() ssh string: $((n + 1)), $(ls -dt ...), $keep in the comment — these were being expanded by the local shell under set -u, causing 'n: unbound variable' All reachable hosts now receive updated merged/ content.
deploy.sh: - Resolve remote destination using $HOME before ssh-streaming so paths such as ~/.bashrc expand correctly on QNAP. - Log manifest transfer phase consistently. merged-qnap/.bashrc: - Show neofetch once per interactive shell when available. - Fallback to [DEPLOY] OS/arch banner when neofetch is absent. - Set NEOFETCH_RAN to avoid repeated display. Verified QNAP /root/.bashrc renders fallback banner.
- Check /root/bin/neofetch first, run if available - Fall back to /root/bin/ufetch if neofetch absent - Use NEOFETCH_RAN and UFETCH_RAN guards to avoid double-runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK-11 (3375fee) rewrote deploy.sh to batch SSH round trips, but the actual file transfer loop was lost — the comment at line 300 was replaced with a colon (:) no-op. The deploy_remote() function built dsts/srcs/kinds arrays and ran backup/chmod/verify, but never called push() to copy files to remote hosts.
This caused every deploy since TASK-11 to report size mismatches while leaving remote files untouched. The chtw alias (removed locally in merged/.bash_aliases) persisted on all fleet hosts.
Changes:
Verified: