Skip to content

Skip Manila checks when catalog show returns empty JSON #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
imatza-rh wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Skip Manila checks when catalog show returns empty JSON #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda89b5
Fix Swift registry check using wrong separator in object name search
imatza-rh Aug 31, 2026
cb725cb
Skip Manila verification when catalog JSON is empty.
imatza-rh Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion collection/stages/roles/verification/tasks/check_registry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
- name: Get the images objects in swift for the {{ swift_check_ns }} namespace from the containers
ansible.builtin.shell: |
set -o pipefail
target="{{ swift_check_ns }}.{{ swift_check_image }}"
target="{{ swift_check_ns }}/{{ swift_check_image }}"
openstack container list -f json \
| jq -r '.[] | (.Name // .name // empty)' \
| while read -r container; do
Expand Down
4 changes: 3 additions & 1 deletion collection/stages/roles/verification/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@
when:
- not _skip_health
- installation_type != 'upi'
- manila_enabled.rc == 0
# catalog show -f json returns rc=0 and "{}" when the service is missing
# (PR #32). Ansible when lists are not short-circuit; default empty JSON.
- manila_enabled.rc == 0 and ((manila_enabled.stdout | default('{}', true) | from_json | length) > 0)
- ceph_nfs_ready|default(true)|bool
- edge_nova_az is not defined # Skip due to Openstack Manila is not supported at the Edge
- not openshift_proxy_installation|default(false)|bool
Expand Down
Loading