Repository navigation
fix: review large changes in task units and find existing code by responsibility - #107
Merged
Merged
Conversation
…code by responsibility - Review Medium and Large changes in units of completed Work Plan tasks: a consuming task with the tasks it depends on, and one shared unit for tasks several units depend on. security-reviewer still reviews the complete change once. - Rerun the reviewer that reported a finding, plus any passed reviewer whose scope (implementation files, applicable ACs, contracts, or trust boundaries) the correction diff changes. - code-reviewer judges criteria instead of building a whole-change map and no longer returns the acceptanceCriteria inventory; its rerun boundary is derived from the correction diff. - Find existing code by responsibility as well as by name, stop searching once the candidates that could change the decision have been read, and keep code separate only on evidence of different contracts or change reasons. - Task executors report evidence per Completion Criteria item and problems observed outside the change; the orchestrator lists unhandled ones in the completion report. - Task files list a test file only when the Work Plan fixes it. - Code comments do not reference tasks, plans, or document sections. - recipe-front-adjust loads the implementation skills before the parent session edits code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on; tasks that several units depend on form one shared unit. One code-reviewer judges each unit with the unit's tasks as task scope, so a large change no longer has one reviewer reading every file. security-reviewer still reviews the complete change once.acceptanceCriteriainventory, which no consumer read. Each unfulfilled AC still has one finding. The rerun boundary is derived from the correction diff.completionCriteria(evidence per Completion Criteria item), which the orchestrator uses to mark completion, andfindingsOutsideChange(problems observed but left outside the change, with no new search obligation). Unhandled items appear in the completion report.coding-rules,ai-development-guide, andimplementation-approachbefore the parent session edits code, andtestingbefore tests change.Validation
npm test: 23 Node tests and 6 Python tests passed.completionCriteriaand reported a seeded out-of-scope bug throughfindingsOutsideChange, which reached the completion report.🤖 Generated with Claude Code