ci: publish nightly on demand only - #30
Merged
Merged
Conversation
The Nightly workflow ran on every push to main, and its publish step force-moves the `nightly` tag and uploads assets with --clobber. That made every commit to main an immediate release to early-access users, with no decision point. Drop the push trigger so nightly is workflow_dispatch only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR makes nightly releases explicitly on-demand.
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The workflow remains manually dispatchable, and the build and publication logic is unchanged; only the unintended automatic trigger is removed. Important Files Changed
Reviews (1): Last reviewed commit: "ci: publish nightly on demand only" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nightly workflow triggered on every push to
main:Its publish step is not passive — it force-moves the
nightlytag and clobbers the rolling release's assets:So every commit to
mainshipped straight to early-access users with no decision point. Publishing a nightly is a release decision; it shouldn't be a side effect of a push.This drops the
pushtrigger, leavingworkflow_dispatchonly. Trigger deliberately:No change to the build or publish logic itself.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.