Skip to content

ci: publish nightly on demand only - #30

Merged
shivamhwp merged 1 commit into
mainfrom
ci/nightly-manual-only
Jul 29, 2026
Merged

ci: publish nightly on demand only#30
shivamhwp merged 1 commit into
mainfrom
ci/nightly-manual-only

Conversation

@shivamhwp

@shivamhwp shivamhwp commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

The Nightly workflow triggered on every push to main:

on:
  push:
    branches:
      - main
  workflow_dispatch:

Its publish step is not passive — it force-moves the nightly tag and clobbers the rolling release's assets:

git tag -f nightly "$COMMIT_SHA"
git push origin refs/tags/nightly --force
gh release upload nightly "${assets[@]}" --clobber

So every commit to main shipped straight to early-access users with no decision point. Publishing a nightly is a release decision; it shouldn't be a side effect of a push.

This drops the push trigger, leaving workflow_dispatch only. Trigger deliberately:

gh workflow run Nightly            # main's tip
gh workflow run Nightly --ref <ref>   # or any other ref

No change to the build or publish logic itself.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

The Nightly workflow ran on every push to main, and its publish step
force-moves the `nightly` tag and uploads assets with --clobber. That made
every commit to main an immediate release to early-access users, with no
decision point.

Drop the push trigger so nightly is workflow_dispatch only.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
wrec Ready Ready Preview Jul 29, 2026 11:01pm

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes nightly releases explicitly on-demand.

  • Removes the push trigger for main.
  • Retains manual workflow_dispatch execution.
  • Documents why publishing must be deliberately triggered.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The workflow remains manually dispatchable, and the build and publication logic is unchanged; only the unintended automatic trigger is removed.

Important Files Changed

Filename Overview
.github/workflows/nightly.yml Removes automatic nightly publication on main pushes while preserving the existing manual build and release workflow.

Reviews (1): Last reviewed commit: "ci: publish nightly on demand only" | Re-trigger Greptile

@shivamhwp
shivamhwp merged commit ecc822a into main Jul 29, 2026
9 checks passed
@shivamhwp
shivamhwp deleted the ci/nightly-manual-only branch July 29, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant