refactor(select): use @angular/aria - #2595
Open
chintankavathia wants to merge 1 commit into
Open
Conversation
chintankavathia
force-pushed
the
refactor/select/use-aria
branch
5 times, most recently
from
August 21, 2026 10:32
9af2e0e to
dfc7ebc
Compare
chintankavathia
force-pushed
the
refactor/select/use-aria
branch
from
August 21, 2026 12:12
dfc7ebc to
c847196
Compare
chintankavathia
marked this pull request as ready for review
August 24, 2026 09:08
spike-rabbit
requested changes
Aug 24, 2026
spike-rabbit
left a comment
spike-rabbit
left a comment
Member
There was a problem hiding this comment.
What about splitting this PR a little bit up.
- What are the differences between the aria and cdk listbox?
- What about the select with filter?
- If it makes sense to use the aria one, we should change this in a separate PR.
- I had the plan to use the siCustomSelect things to built the actual select. Maybe we should do this refactor first. And then just migrate the custom select directive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces manual aria attributes binding with @angular/aria combobox primitives
related to #1070 , #2569
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: