Skip to content

feat(split)!: migrate showCollapseButton to collapsible - #2599

Merged
spike-rabbit merged 1 commit into
mainfrom
feat/drop-show-collapse-button-input
Aug 28, 2026
Merged

feat(split)!: migrate showCollapseButton to collapsible#2599
spike-rabbit merged 1 commit into
mainfrom
feat/drop-show-collapse-button-input

Conversation

@spliffone

@spliffone spliffone commented Aug 21, 2026

Copy link
Copy Markdown
Member

Closes #2596

BREAKING CHANGE: The showCollapseButton input on si-split-part has been removed.

The collapse button will now be rendered when the collapsible input is provided.

Before:

<si-split>
  <si-split-part showCollapseButton="false" ... />
  <si-split-part showCollapseButton="true" ... />
</si-split>

After:

<si-split>
  <!-- The collapse button won't be rendered when the collapsible input is not provided -->
  <si-split-part ... />
  <!-- The collapse button will be rendered when the collapsible input is provided -->
  <si-split-part collapsible="to-start" ... />
</si-split>

Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@spliffone
spliffone requested review from a team as code owners August 21, 2026 10:45

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the migration is not ideal. I think if showCollapsedButton is false, you can just remove that property.

But you need to add collapsible, if no direction is provided an no showCollapseButton false is set

@spike-rabbit spike-rabbit added this to the 51.0.0 milestone Aug 21, 2026
@spliffone
spliffone force-pushed the feat/drop-show-collapse-button-input branch from b87597d to 972ec4c Compare August 24, 2026 17:56
Closes #2596

BREAKING CHANGE: The `showCollapseButton` input on si-split-part has been removed.

The collapse button will now be rendered when the `collapsible` input is provided.

Before:

```html
<si-split>
  <si-split-part showCollapseButton="false" ... />
  <si-split-part showCollapseButton="true" ... />
</si-split>
```

After:

```html
<si-split>
  <!-- The collapse button won't be rendered when the collapsible input is not provided -->
  <si-split-part ... />
  <!-- The collapse button will be rendered when the collapsible input is provided -->
  <si-split-part collapsible="to-start" ... />
</si-split>
```
@spliffone
spliffone force-pushed the feat/drop-show-collapse-button-input branch from 972ec4c to f51d8da Compare August 24, 2026 18:00
@spliffone
spliffone requested a review from spike-rabbit August 24, 2026 18:00

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit
spike-rabbit added this pull request to the merge queue Aug 28, 2026
Merged via the queue into main with commit 6a8bf77 Aug 28, 2026
15 checks passed
@spike-rabbit
spike-rabbit deleted the feat/drop-show-collapse-button-input branch August 28, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split: drop showCollapseButton input

2 participants