build(skills): manage third-party skills with skills.sh - #2616
Open
spike-rabbit wants to merge 1 commit into
Open
build(skills): manage third-party skills with skills.sh#2616spike-rabbit wants to merge 1 commit into
spike-rabbit wants to merge 1 commit into
Conversation
spike-rabbit
force-pushed
the
build/update-playwright-skill
branch
from
August 25, 2026 09:13
22543e5 to
d5ea680
Compare
spike-rabbit
changed the title
spike-rabbit
marked this pull request as ready for review
August 25, 2026 13:21
spike-rabbit
added
the
core-team-discussion
kfenner
reviewed
Aug 27, 2026
Member
|
I think this is fine for the moment. Even if skills.sh is not a real standard yet, we can change the solution at any time. IMHO, we can move forward with this 👍 |
kfenner
added
discussion
chintankavathia
requested changes
Aug 27, 2026
Comment on lines
+79
to
+81
| When adding a third-party skill, add its path under `.agents/skills/` to | ||
| `.prettierignore`. Third-party skill sources must not be reformatted by this | ||
| repository's Prettier configuration. |
Member
There was a problem hiding this comment.
how about just using wildcard in prettierignore for skills folder
Member
Author
There was a problem hiding this comment.
we have the problem, that the skills we maintain should be formatted by prettier.
Only 3rd part skills should be excluded.
Member
There was a problem hiding this comment.
You can always use negation in that case !skills-maintained-by-us
Member
Author
There was a problem hiding this comment.
the question is what we want here?
- should all skills be formatted by default and we manually exclude the 3rd party ones
- no skill is formatted and we include ours manually
I think we should format all by default. Otherwise we may forget one of ours.
spike-rabbit
force-pushed
the
build/update-playwright-skill
branch
from
August 27, 2026 10:37
d5ea680 to
50b12f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the project policy for managing third-party agent skills with skills.sh via npx skills.\n\nUpdates the Playwright CLI skill from microsoft/playwright-cli, records its source and hash in skills-lock.json, and excludes third-party skill sources from Prettier formatting.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: