Skip to content

fix(renderer): make Scene Lab wireframe toggle visually distinct - #24

Merged
simonhagger merged 1 commit into
mainfrom
fix/scene-lab-wireframe
Aug 24, 2026
Merged

fix(renderer): make Scene Lab wireframe toggle visually distinct#24
simonhagger merged 1 commit into
mainfrom
fix/scene-lab-wireframe

Conversation

@simonhagger

Copy link
Copy Markdown
Owner

Summary

  • Torus knot geometry was dense enough (220x28) that wireframe rendering looked nearly identical to solid shading; reduced to 128x16 so the toggle is clearly visible
  • Material state now applied via \�pplyMaterialState()\ both after scene init and from the signal effect, removing reliance on effect scheduling for post-init state

Validation


  • enderer:lint\ +
    enderer:test\ + dev build green
  • Live check: wireframe on/off clearly distinct; accent + star color unchanged in behavior

Security Checklist

  • Security review completed
  • Threat model updated or N/A explained
  • Confirmed no secrets/sensitive data present in committed files

- Reduce torus knot density (220x28 -> 128x16) so wireframe shows
  structure instead of collapsing into near-solid noise
- Extract applyMaterialState(); call it after scene init so current
  signal state applies regardless of effect scheduling
@simonhagger
simonhagger merged commit ae758d4 into main Aug 24, 2026
16 checks passed
@simonhagger
simonhagger deleted the fix/scene-lab-wireframe branch August 24, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant