fix: follow up to #45 - #47
Merged
Merged
Conversation
… the curl exit code in API failure messages
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to #45 that tightens up the shell implementation and accompanying docs: it clarifies installation via a stable ell launcher, makes plugin hook handling more robust, improves error reporting for backend HTTP failures, and hardens JSON parsing.
Changes:
- Document an alternative install method by symlinking the
elllauncher into~/.local/bin(and explain why to linkell, notell.sh). - Improve shell robustness by scoping variables with
local, reading plugin hook lists into arrays viamapfile, and enhancing curl failure diagnostics. - Harden JSON number parsing by validating scanned number tokens against RFC 8259 grammar.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds symlink-based install guidance referencing the ell launcher. |
| plugins/paginator/90_pre_output.sh | Adds local scoping for cursor-position helper variables. |
| llm_backends/openai/generate_completion.sh | Captures curl exit status for clearer fatal errors; returns non-zero on JSON parse failure. |
| llm_backends/gemini/generate_completion.sh | Same curl-status handling and JSON-parse failure behavior as OpenAI backend. |
| helpers/piping.sh | Scopes the internal pipeline command string with local. |
| helpers/parse_arguments.sh | Scopes parsing temporaries with local. |
| helpers/load_config.sh | Scopes config loader temporaries with local. |
| helpers/json.sh | Validates JSON number tokens against RFC 8259 number grammar. |
| ell.sh | Uses mapfile to treat plugin hook lists as arrays and improves related debug output. |
| docs/Configuration.md | Updates documented default ELL_TEMPLATE to default-openai to match the script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.