Repository navigation
v1.8.2: return on collateral for short puts, no ROI on futures notional - #54
Merged
Merged
Conversation
- Short puts show Net ROI (on premium) plus Collateral (strike x 100) and Return on Collateral. - Futures no longer show ROI: a return on notional says nothing about return on margin. Adjusted Cost still shows the notional. - Options and futures count "Contracts traded" instead of "Stocks traded". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test
New
TradeDetail.test.jscase: a short 165 put sold 6.50 and bought 4.63 shows a $650 cost, +28.56% on premium, $16,500 collateral, +1.13% on collateral. The futures test now checks that ROI is null. 9/9 pass.🤖 Generated with Claude Code