Skip to content

v1.8.2: return on collateral for short puts, no ROI on futures notional - #54

Merged
simonro merged 1 commit into
mainfrom
fix/roi-collateral
Nov 16, 2026
Merged

simonro merged 1 commit into
mainfrom
fix/roi-collateral

Conversation

@simonro

@simonro simonro commented Nov 12, 2026

Copy link
Copy Markdown
Owner

What

  • Short puts: Net ROI is labeled "on premium", plus new Collateral (strike x 100 x contracts) and Return on Collateral rows.
  • Futures: ROI is hidden. ROI on notional says nothing about return on margin. Adjusted Cost still shows notional.
  • Options and futures show "Contracts traded" instead of "Stocks traded".

Test

New TradeDetail.test.js case: a short 165 put sold 6.50 and bought 4.63 shows a $650 cost, +28.56% on premium, $16,500 collateral, +1.13% on collateral. The futures test now checks that ROI is null. 9/9 pass.

🤖 Generated with Claude Code

- Short puts show Net ROI (on premium) plus Collateral (strike x 100) and
  Return on Collateral.
- Futures no longer show ROI: a return on notional says nothing about
  return on margin. Adjusted Cost still shows the notional.
- Options and futures count "Contracts traded" instead of "Stocks traded".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@simonro
simonro merged commit 7914f7c into main Nov 16, 2026
3 checks passed
@simonro
simonro deleted the fix/roi-collateral branch November 16, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants