Say and N more when a typed-hole refinement list is cut - #165
Open
amandeavor wants to merge 1 commit into
Open
amandeavor wants to merge 1 commit into
amandeavor wants to merge 1 commit into
Conversation
Direct fits already report how many candidates the shortlist left out; give the `or:` refinement clause the same treatment so readers know the four shown suggestions are a capped shortlist, not the full set.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typed holes already say
and N morewhen the direct-fit (try:) shortlist is capped. The refinement (or:) shortlist was also capped at four candidates, but silently — so a reader could not tell whether those four were the full set.This mirrors the direct-fit behaviour for refinements:
Infer::hole_refinementsnow returns(shortlist, leftover_count)likehole_fitsHolegainsmore_refinementsHole::messageappends, and N moreon theor:clause when the cap left anything outFixes #139.
Test plan
cargo fmtcargo clippy --all-targetscargo test(full suite, including newa_truncated_refinement_list_says_how_many_it_left_out)let r = ["a"] |> List.map ?f |> String.join ","produces a capped refinement list with a non-zero leftover count in the message