Repository navigation
native: a generalized module-level value is annotated with Any - #167
Merged
Merged
Conversation
`let emptyBoard = Map.empty` has type `Map 'k 'v`, which the annotator
could not spell, so the value went unannotated and mypyc stopped on
another module's read of it ("Cannot determine type"). A module-level
value now spells its type variables as `Any` (`dict[Any, Any]`), and the
module imports `Any` when it needs to. Function parameters still leave a
type variable unannotated.
ROADMAP records the first compiled timings of a real program.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let emptyBoard = Map.emptyhas typeMap 'k 'v. The annotator couldn't spell that type, so the value went unannotated, and mypyc stopped with "Cannot determine type" when another module read it. This is the case #166 missed.Any(dict[Any, Any]), and the module importsAnywhen it needs it.Anythere would hide a real signature.With this, a real multi-module program compiles with mypyc on Windows (MSVC, CPython 3.14), and its output matches plain Python. Its move-generation benchmark runs about 1.5x faster compiled. ROADMAP records these timings.
Test:
native_annotates_module_level_values_for_other_modulesnow covers a generic value too.