Repository navigation
feat: add regex-based replace option - #227
Open
RamziSayagh wants to merge 1 commit into
Open
RamziSayagh wants to merge 1 commit into
RamziSayagh wants to merge 1 commit into
Conversation
Trott
requested changes
Nov 18, 2026
Trott
left a comment
Collaborator
There was a problem hiding this comment.
This adds documentation complexity and a maintenance burden for a feature no one has ever asked for or needed and will likely only be used by people confused about what it does. I'm not excited to add a replace option when we already have a sufficiently confusing replacement option. Lastly, if anyone does need this feature, they can simply apply the regex to their input string before sending it to slugify. There's no added benefit to the user (who has to write the regex regardless) in having slugify do this for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
replaceoption to convert regex matches into the configured slug replacement character.Example
Changes
replacebefore transliteration and default character filtering