Repository navigation
feat: add strict replacement option - #228
Open
RamziSayagh wants to merge 1 commit into
Open
RamziSayagh wants to merge 1 commit into
RamziSayagh wants to merge 1 commit into
Conversation
Trott
requested changes
Nov 18, 2026
Trott
left a comment
Collaborator
There was a problem hiding this comment.
Similar to the other pull request, this seems to be adding a feature just because we can and not because anyone needs it. This adds maintenance burden and a surface for bugs (or just surprising behaviors) for a feature that is not useful. It negatively affects the developer experience because people have to sort out more options (with similar names--strict vs. strictReplace vs. replace) to find the one they actually want, and in return, we get the aforementioned maintenance burden and surface area for bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
strictReplaceoption to replace special characters with the configured replacement character.Example
Changes
strictbehaviorstrictprecedence when both options are enabled