improvement(slack): merge slack_v2 auth into one credential picker for accounts and custom bots#5800
Conversation
…r accounts and custom bots
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview The shared CredentialSelector gains merged-mode combobox groups ( slack_oauth is custom-bot-only: hidden Supporting updates: subblock Reviewed by Cursor Bugbot for commit 19769ef. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR combines Slack v2 authentication into one credential flow. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "improvement(slack): move provider-specif..." | Re-trigger Greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3669a0a. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 85f40a4. Configure here.
…atch out of the credential selector
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 19769ef. Configure here.
Summary
authMethoddropdown is gone — one credential picker (credentialKind: 'any') lists Slack OAuth accounts and custom bots together in a grouped dropdown, with a connect action per group; the credential's kind is resolved server-side fromcredential.typeappTypefield and the sim-mode OAuth picker, event dropdown is the full static catalog, deploy routing always usesroutingKey = botCredentialId(native Sim-app path removed for now — ingest route stays for a future ship)dependsOn: { all: ['authMethod'], ... }gates to['credential']and dropped the dead sim-event constantscustomBotCredential/manualBotCredentialtoCREDENTIAL_SUBBLOCK_IDSso credential deletion cleans trigger referencesType of Change
Testing
Tested manually on a live canvas (merged picker groups + both connect actions, trigger shows no App Type, stale
authMethodignored on load).lint,check:api-validation:strict, typecheck, and slack/deploy/serializer test suites pass; added deploy tests for the bot-credential canonical collapse (branch previously untested).Checklist
🤖 Generated with Claude Code