fix(docker): require persistent auth secrets#5801
Conversation
|
@brainx is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
PR SummaryMedium Risk Overview Self-hosting docs (README, CONTRIBUTING, and localized Docker guides) replace the old inline secret snippet with a one-time, no-clobber shell block that writes a gitignored A Vitest file asserts the compose YAML keeps the required Reviewed by Cursor Bugbot for commit 7c24159. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR makes production Docker Compose fail fast when persistent secrets are missing. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(docker): require persistent auth sec..." | Re-trigger Greptile |
Summary
Root cause
The documented quick start launched production Compose without
BETTER_AUTH_SECRET,ENCRYPTION_KEY, orINTERNAL_API_SECRET. The app root could pass the health check, but Better Auth rejected signup at request time because it fell back to its forbidden production default secret.Fixes #5625
Validation
node ../../node_modules/vitest/vitest.mjs run lib/core/config/docker-compose-secrets.test.ts 'app/api/auth/[...all]/route.test.ts'- 9 passednode node_modules/@biomejs/biome/bin/biome check apps/sim/lib/core/config/docker-compose-secrets.test.ts- passed@mdx-js/mdxsh,bash, andzshgit diff --check- passedLimitations
responseErrorMessageerror inapps/sim/tools/github/create_pr_review.ts:261.docker compose configordocker compose up. The original auth failure and valid-secret control were reproduced against the official images using Apple Container.