Skip to content

improvement(emcn): consistent hugging tab bars via ChipModalTabs#5815

Merged
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+tab-bar-consistency
Jul 21, 2026
Merged

improvement(emcn): consistent hugging tab bars via ChipModalTabs#5815
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+tab-bar-consistency

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Pin ChipModalTabs to w-fit so the segmented pill always hugs its tabs. It renders as an inline-flex trough, but when dropped directly into a flex column (e.g. settings pages) flexbox blockifies it and align-items: stretch stretched it full-width. w-fit keeps it hugging in every layout; a caller-supplied width class still wins.
  • Migrate the mothership settings tab bar off a hand-rolled full-width underline bar onto the shared ChipModalTabs pill.
  • Fix an undefined --border-secondary token in mothership (used nowhere else in the app, so it silently fell back to currentColor) → --border, matching the admin settings precedent. Also aligned one text-xs cell to text-caption for row consistency.

Type of Change

  • Improvement / bug fix

Testing

Tested manually; biome clean on both files, tsc shows only pre-existing unrelated errors.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

- Pin ChipModalTabs to w-fit so the segmented pill always hugs its tabs
  instead of stretching full-width when dropped into a flex column
- Migrate the mothership settings tab bar off a hand-rolled full-width
  underline bar onto ChipModalTabs
- Fix undefined --border-secondary token (fell back to currentColor) in
  mothership -> --border, matching the admin settings precedent
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jul 21, 2026 8:24pm

Request Review

@cursor

cursor Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Visual and design-token fixes on an admin settings screen; no auth, data, or API behavior changes.

Overview
ChipModalTabs now applies w-fit on the underlying ChipSwitch so the segmented pill stays content-sized in flex column layouts (where stretch used to make it full-width). Caller className can still override width.

Mothership settings drops the custom full-width underline tab row in favor of ChipModalTabs, aligned with other tabbed surfaces.

On the same page, table and card borders move from the undefined --border-secondary token (silent currentColor fallback) to --border, and one request row uses text-caption instead of text-xs for typography consistency.

Reviewed by Cursor Bugbot for commit b8d1880. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR standardizes the Mothership settings tabs and related styling. The main changes are:

  • Replaces the hand-built tab bar with ChipModalTabs.
  • Makes ChipModalTabs shrink-wrap its tabs by default.
  • Replaces undefined border tokens with the canonical divider token.
  • Aligns request ID typography with neighboring cells.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/mothership/mothership.tsx Moves settings navigation to ChipModalTabs and standardizes border and text tokens.
packages/emcn/src/components/chip-modal/chip-modal.tsx Adds a shrink-wrapped default width while preserving caller width overrides.

Reviews (1): Last reviewed commit: "improvement(emcn): consistent hugging ta..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 94b2334 into staging Jul 21, 2026
20 checks passed
@waleedlatif1
waleedlatif1 deleted the worktree-fix+tab-bar-consistency branch July 21, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant