improvement(emcn): consistent hugging tab bars via ChipModalTabs#5815
Conversation
- Pin ChipModalTabs to w-fit so the segmented pill always hugs its tabs instead of stretching full-width when dropped into a flex column - Migrate the mothership settings tab bar off a hand-rolled full-width underline bar onto ChipModalTabs - Fix undefined --border-secondary token (fell back to currentColor) in mothership -> --border, matching the admin settings precedent
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Mothership settings drops the custom full-width underline tab row in favor of On the same page, table and card borders move from the undefined Reviewed by Cursor Bugbot for commit b8d1880. Configure here. |
Greptile SummaryThis PR standardizes the Mothership settings tabs and related styling. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "improvement(emcn): consistent hugging ta..." | Re-trigger Greptile |
Summary
ChipModalTabstow-fitso the segmented pill always hugs its tabs. It renders as aninline-flextrough, but when dropped directly into a flex column (e.g. settings pages) flexbox blockifies it andalign-items: stretchstretched it full-width.w-fitkeeps it hugging in every layout; a caller-supplied width class still wins.ChipModalTabspill.--border-secondarytoken in mothership (used nowhere else in the app, so it silently fell back tocurrentColor) →--border, matching theadminsettings precedent. Also aligned onetext-xscell totext-captionfor row consistency.Type of Change
Testing
Tested manually;
biomeclean on both files,tscshows only pre-existing unrelated errors.Checklist