Repository navigation
feat(greenhouse): connect Harvest v3 with a customer-owned API credential - #9214
Merged
Merged
Conversation
…tial - Save a Greenhouse Harvest V3 (OAuth) client ID and secret as a reusable credential; Sim mints access tokens with the client credentials grant - The Greenhouse block offers saved credentials alongside partner OAuth, so it works on deployments without partner OAuth credentials - Document the Dev Center setup
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review. SummaryAdds customer-owned Greenhouse Harvest v3 credentials alongside partner OAuth.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
greenhouse-service-accountclient-credential provider: users save their own Greenhouse Harvest V3 (OAuth) client ID and secret, and Sim mints access tokens with the client credentials grant (grant_type=client_credentials, Basic auth, no requested scopes — scopes live on the credential in Greenhouse)credentialKind: 'any'), the same shape as Ramp, so the block is available on deployments withoutGREENHOUSE_CLIENT_ID/GREENHOUSE_CLIENT_SECRETinstead of disappearing from the toolbarType of Change
Testing
credential-display.test.ts,token-resolution.test.ts,availability.server.test.ts(77 passed), with Greenhouse rows added to the existing service-account coverage tablesbun run lint, block-registry check,check:deployment-config,check:integration-catalog,check:docs,check:docs-manifest,check:utils,check:comment-hygiene,check:unused-exports,check:explicit-any,check:file-names,check:source-conventionsservice-account-providers.generated.tsviagenerate:deployment-config; full type-check and audits run in CIChecklist
test-auditauthoring gate)