Repository navigation
fix(tables): keep leading-zero codes as text when inferring CSV column types - #9754
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge. SummaryKeeps leading-zero CSV codes as text when choosing types for new tables and newly added columns.
Reviews (1) · Last reviewed commit: "fix(tables): keep leading-zero codes as ..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numberwhenever every sampled value parsed withNumber(), so ZIP codes, phone numbers, and SKUs like02134were stored as2134and the leading zero was lost for goodinferColumnTypenow treats a value with a leading zero followed by another digit as text;0,0.5, and-0.5still infer as numbersType of Change
Testing
lib/table/import.test.ts, shown red on the pre-fix code, green afterlib/table/import.test.ts+lib/table/import-runner.test.tspass (47 tests)Checklist
test-auditauthoring gate)