Skip to content

chore(infra): remove dead tempo ingester config - #3806

Open
manamana32321 wants to merge 3 commits into
mainfrom
t3079-tempo-mcp-server
Open

manamana32321 wants to merge 3 commits into
mainfrom
t3079-tempo-mcp-server

Conversation

@manamana32321

@manamana32321 manamana32321 commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Description

infra/k8s/monitoring/tempo/values.yaml의 structuredConfig 블록을 지웁니다.

이 키는 우리가 쓰는 tempo 차트에 없는 키입니다(tempo-distributed 차트 것). 그래서 그 아래 적어둔 ingester 설정값들은 한 번도 Tempo에 전달된 적이 없습니다. 동작은 그대로이고 오해만 일으키던 설정을 치우는 변경입니다.

이 PR은 처음에 Tempo 자체 MCP 서버를 켜는 작업으로 시작했는데, 켜도 효과가 없다는 걸 확인해서 그 부분은 되돌렸습니다.

Additional context

죽은 설정이라는 근거 — 차트를 렌더해보면 삭제 전과 후의 출력이 완전히 같습니다.

helm template tempo grafana/tempo --version 1.24.4 -f values.yaml
→ 삭제 전/후 출력이 바이트 단위로 동일

MCP 서버 설정을 되돌린 근거 — Grafana를 두 개 띄워 연결된 도구 목록을 비교했습니다.

Tempo /api/mcp 응답 도구 수
2.8.2, 설정 없음 404 62
2.9.0, 설정 켬 200 62

/api/mcp는 분명히 켜졌는데 도구가 한 개도 늘지 않았습니다. Grafana MCP는 Tempo에 그 주소로 접근하지 않고 Grafana의 데이터소스 프록시를 거치기 때문입니다. 트레이스 검색·조회·메트릭 질의는 이 설정 없이 이미 다 됩니다.

Before submitting the PR, please make sure you do the following

Closes TAS-3079

🤖 Generated with Claude Code

The agent reaches traces through Grafana MCP, which registers its
tempo_* tools only after probing /api/mcp on the Tempo datasource.
Tempo serves that endpoint from 2.9 but keeps it off by default.

Drop structuredConfig while here: the tempo chart has no such key
(it belongs to tempo-distributed), so the ingester tuning under it
was never rendered. Confirmed by helm template, which emits an
empty ingester block both before and after this change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@manamana32321 manamana32321 self-assigned this Oct 3, 2026
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6cdc562e-93ee-4eb2-9023-ff5d7c7e6282
📥 Commits

Reviewing files that changed from the base of the PR and between 5a20011 and adea7d3.

📒 Files selected for processing (1)
  • infra/k8s/monitoring/tempo/values.yaml
💤 Files with no reviewable changes (1)
  • infra/k8s/monitoring/tempo/values.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Tempo values configuration no longer sets explicit ingester values for maximum block size, maximum block duration, or complete block timeout.

Changes

Tempo ingester settings

Layer / File(s) Summary
Remove explicit ingester settings
infra/k8s/monitoring/tempo/values.yaml
Removed explicit settings for max_block_bytes, max_block_duration, and complete_block_timeout.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to adea7

The change is a small values cleanup that is reported to leave the rendered Tempo configuration unchanged. No actionable merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title says the pull request enables Tempo’s MCP server, but the final change removes explicit ingester settings and does not enable the MCP server. Change the title to describe the final change, such as “Remove explicit Tempo ingester settings.”
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The local stack ran Tempo 2.8.2, which predates the MCP server, so
the endpoint the agent probes could not exist there. Bump it to
2.9.0 and turn the same flag on, keeping local and production
aligned for this feature.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…423e

Enabling Tempo's own MCP server adds no tools to the Grafana MCP server.
Verified by diffing tools/list against two Grafana instances: one with
Tempo 2.8.2 and no mcp_server, one with Tempo 2.9.0 and mcp_server
enabled. Both expose the same 62 tools.

mcp-grafana reaches Tempo through the Grafana datasource proxy
(/api/datasources/proxy/uid/<uid>/api/search), not through /api/mcp.
Its --disable-proxied flag is now an alias for --disable-tempo, so the
proxied path these settings targeted no longer exists.

The structuredConfig removal stays. That key does not exist in the tempo
chart, so helm template renders identically with and without it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@pull-request-size pull-request-size Bot added size/XS and removed size/S labels Oct 3, 2026
@manamana32321 manamana32321 changed the title feat(infra): enable tempo mcp server chore(infra): remove dead tempo ingester config Oct 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant