Repository navigation
refactor(infra): move alloy river config to a file - #3807
manamana32321 wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe98c06c40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fe98c06 to
e3a21df
Compare
|
@coderabbitai review |
|
The River config was 89 of the 147 lines in values.yaml, inlined under
`alloy.configMap.content`. Inside a YAML string it gets no River syntax
highlighting, `alloy fmt` cannot reach it, and validating it means
rendering the ConfigMap and extracting the value again.
Move it to config.alloy and inject it through the ApplicationSet's
`helm.fileParameters`, which resolves multi-source `$ref` paths the same
way `valueFiles` does. The environment label now reads
`sys.env("ALLOY_ENVIRONMENT")` instead of `{{ .Values.environment }}`,
set per environment through `alloy.extraEnv`, so the file stays plain
River and `alloy validate` parses it directly.
`*.alloy` goes in .prettierignore because the lefthook pre-commit hook
runs prettier without `--ignore-unknown`, unlike CI.
Rendered output is unchanged apart from the environment label resolving
at runtime instead of at render time.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
e3a21df to
5143249
Compare
This branch has not been deployed
1 participant
Description
Alloy 설정 파일을 읽기 쉽게 분리합니다. 동작은 바뀌지 않습니다.
배포 순서 주의
머지 후 release 승급까지 production Alloy가 ArgoCD에서 빨갛게 뜹니다. 의도된 것이고 수집은 계속됩니다.
이유: ApplicationSet 매니페스트는
main에서 바로 배포되는데, 그 안의 production 설정은 파일을release브랜치에서 찾습니다.config.alloy가 아직release에 없어서 production 쪽 설정 조립이 실패합니다.Before submitting the PR, please make sure you do the following
fixes #123).🤖 Generated with Claude Code