Repository navigation
feat(frontend): one public entry point (public-api) with an exports map - #999
Merged
smart-ssh-coordinator[bot] merged 1 commit intoOct 28, 2026
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
7 tasks
7 tasks
There was a problem hiding this comment.
Review
Verdict: approved
Review level: normal
Blocking
None.
Non-blocking
- No changelog fragment; the stability rule in the header says exports change with a changelog entry, but this PR adds no user-visible behaviour, so it is acceptable.
Verified
- counter-proof: removing the
useIsNarrowre-export turnspublicApi.test.ts"exports every listed name" red; restored → green (executed: vitest run src/publicApi.test.ts) - edge cases: internal path
smart-ssh/src/apidoes not resolve;invokeCommandrethrows the identical error object; non-locked rejection publishes nothing → ok (read + executed) - callers checked:
invokein api.ts is now an alias of the exportedinvokeCommand→ internal call sites are unchanged - tests run locally:
npx vitest run src/publicApi.test.ts→ 5 passed (executed);npx tsc -bclean;npm run lintonly warnings (executed) - CI: all checks green, including Browser Tests and the Test jobs on 3 platforms
- UI: not a UI change
- data: not touched
- files read: 6/6 logic files
Timing analysis
- 1 test file analysed (read): no timing dependency; the tests are synchronous or await a single promise.
Spec
- visible behaviour changed: none for users; the embedding contract is new
- spec searched (public-api, extension, entitlements, exports), spec covering it: 0038 §4, updated and matching the code
- verdict: spec change present and matches the code
Security checks
- Re-exports only, no new boundary. The
feature_lockedhandling is preserved. No filter, redaction or credential paths touched.
Follow-ups
None.
smart-ssh-coordinator
Bot
deleted the
issue-886-frontend-one-public-entry-point-public
branch
October 28, 2026 00:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #886
Summary
Adds
src/public-api.ts(re-exports only) andsrc/test-support.ts, exports the central wrapper asinvokeCommand, and adds anexportsmap with exactly./public-apiand./test-support. Spec 0038 §4 documents the surface.Acceptance Criteria
src/publicApi.test.ts:exports every listed name,test-support exports the matchMedia helpers)invokeCommandbehaviour: met (publicApi.test.ts:publishes feature_locked and rethrows the same error,publishes nothing for other rejections)exportshas exactly two entries; build/test/e2e: met for tsc, lint, vitest locally; build/e2e left to CIpublicApi.test.ts:resolves by package name through the exports map, also asserts internal paths do not resolve)useIsNarrowre-export → test red, restored → green; documented in the test header)npm run check-commandsincluded in lint)Tests
vitest full suite green; new test 10× repeated green.
Assumptions
Button/Fieldetc. are checked as functions/objects as they actually are at runtime.Spec: updated 0038
Threat model: no change – re-exports only, no new boundary.
Manual test steps
None.
Follow-ups
None.
🤖 Generated with Claude Code