Repository navigation
Share page: show the video's description, chapters and tags - #108
Merged
Merged
Conversation
The description sits under the title; its chapter lines are times that jump the player there (and #t=90 in the address starts at 90 s). Tags show as labels. The description's opening becomes the link preview text (og:description, twitter:description). Links without a description look as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The share page (
functions/s/[id].js) shows what the app now sends with a share link:#t=90in the address starts at 90 sog:description,twitter:description)The share function and the
description/tagscolumns are already deployed. Links without a description look as before. Merging deploys the site throughsite.yml.