Repository navigation
Fix headline fonts in light mode - #14
Merged
Merged
Conversation
--sl-mono, --sl-display, --sl-headline and --sl-serif sat inside [data-theme='dark']. In light mode (the default) they were undefined, so headlines fell back to Space Grotesk with Inter Tight's tracking and weight, and the accent became a synthesized italic. Type is theme-independent; it now lives in :root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #12, headlines look wrong in light mode, which is the default for first-time visitors.
Cause: the type variables (
--sl-mono,--sl-display,--sl-headline,--sl-serif) were defined inside[data-theme='dark']only. In light mode they were undefined, so:Fix: move the four variables into
:root. Type doesn't change between themes; colors stay in their theme blocks.Testing:
npm run buildsucceeds, and the built CSS defines--sl-headlinein:root. I confirmed Google Fonts serves Inter Tight 500/600 and Instrument Serif (regular and italic). Not yet checked visually in a browser.