ci: run Build and Style on the release branches too - #314
Merged
Conversation
Both workflows only triggered on main, yet tags are cut on release/vX.Y — the very commits a release points at were the only ones never built. Add release/** to the push and pull_request triggers so a patch release is validated before it is tagged, and document the pre-tag check in release_process.rst (the Docs workflow already runs on every ref).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both workflows only triggered on
main, yet tags are cut onrelease/vX.Y— so the very commits a release points at were the only ones never built. That is the structural half of howv6.2.4shipped a tree no fresh clone could build (the other half, the materialized lvgl files, is fixed by #313).build.yml/style.yml: addrelease/**to thepushandpull_requesttriggers (Docsalready runs on every ref).release_process.rst: a short "Before tagging: check the CI" section, pointing atgh run list --workflow Build --branch release/v6.2, and noting thatbuild (virt32)/build (virt64)are now required status checks onmain.Prerequisite for cutting
v6.2.5onrelease/v6.2with CI validation.