Skip to content

Nightly audit 2026-11-14: misplaced rustdocs, dead resolve_name - #298

Draft
smarzban wants to merge 2 commits into
mainfrom
feat/nightly-audit-2026-11-14-docs-e79e
Draft

smarzban wants to merge 2 commits into
mainfrom
feat/nightly-audit-2026-11-14-docs-e79e

Conversation

@smarzban

@smarzban smarzban commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Why

Rustdocs on several UI and app items described a different function than the one they sat on, and a few links pointed at names that do not exist. AgentProfiles::resolve_name had zero callers.

What changed

  • Moved accurate rustdoc paragraphs onto the functions they describe (paint_status_line, paint_verb_bar, apply_board_intent_with_save_recovery, edit_chrome_row, and map_capture_key_state) and fixed or dropped the rest.
  • Dropped the emptied ticket crumbs on CommandChrome and DeleteNoticeUndo.
  • Deleted unused AgentProfiles::resolve_name.

Scope

Blast Radius

No runtime behavior change. Reviewers and cargo doc readers are the only consumers.

Verification

  • cargo fmt --check, cargo clippy --all-targets -- -D warnings, cargo test --lib, cargo doc --no-deps: pass.
  • Full cargo test: green except pre-existing git_base::two_tsk_processes_on_one_state_dir_share_one_fetch flake (also fails on clean main here).
Open in Web Open in Cursor 

@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
herdr-tsk Ignored Ignored Preview Nov 15, 2026 2:30am UTC

cursoragent and others added 2 commits November 15, 2026 02:28
Move accurate paragraphs onto paint_status_line, paint_verb_bar,
apply_board_intent_with_save_recovery, edit_chrome_row, and
map_capture_key_state. Fix broken intra-doc targets and delete docs
that described a different item than the one they sat on.

Co-authored-by: Saeed <smarzban@users.noreply.github.com>
Zero callers repo-wide. Assignee resolution already goes through
resolve_assignee.

Co-authored-by: Saeed <smarzban@users.noreply.github.com>
@cursor
cursor Bot force-pushed the feat/nightly-audit-2026-11-14-docs-e79e branch from 35f4038 to aa69280 Compare November 15, 2026 02:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants