fix(latex): correct the observed pull request count - #160
Open
toshi0806 wants to merge 1 commit into
Open
Conversation
The nine counted two lock file maintenance pull requests in this repository, which has no lock file and therefore cannot produce one -- the paragraph above says as much. They were action updates whose release notes happened to contain the phrase, and a full-text `gh search prs` matched on the body rather than the title. Seven across ai-academic-paper-reviewer and texlive-ja-textlint is the real figure, and naming the two repositories as the ones that carry lock files makes the count checkable. The argument is unchanged. Refs #157
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "The concurrent-PR cap throttles the same queue from the other end. Majors are never auto-merged, so they stay open until they are reviewed; under the inherited cap of ten they hold the quota and the auto-merged minor/patch lane stops being refilled -- the same starvation as above, at a different valve. The window is the only throttle either limit needs to leave in place.", | ||
| "Refresh lock files weekly, in a narrow window on the first day of the one above. Bumping direct dependencies never rewrites the rest of the tree, so advisories in transitive packages accumulate unseen -- the eleven advisories found in ai-academic-paper-reviewer were almost all transitive. Lock file maintenance carries its own schedule that the top-level one does not override, so a window has to be named here; leaving it out would fall back to Renovate's Monday-early default and split the week into two update waves. Take the shape of that default -- one day, before dawn -- and move only the day. This lives in the latex preset rather than the npm one because the window is defined here, and it is a no-op for repositories that have no lock file.", | ||
| "Keep that window narrower than the two-day one above, because the reasoning for widening does not carry here. A version update is an item that a job can exhaust; lock file maintenance is the difference between the committed lock file and the registry. Merging it restores that difference within hours, so the next job inside the window has something to create again. Across 2026-08-27 to 08-29 that produced nine pull requests over three repositories, one of them opened thirty-six seconds after its predecessor merged, each carrying a single transitive package where one weekly pull request would have carried all of them. Five hours still exceeds the four-hour job interval, so this window cannot fall between two jobs the way the Sunday evening one did. Nothing urgent rides on the cadence either: osvVulnerabilityAlerts in the default preset bypasses every schedule, which leaves lock file maintenance a routine refresh rather than the security net." | ||
| "Keep that window narrower than the two-day one above, because the reasoning for widening does not carry here. A version update is an item that a job can exhaust; lock file maintenance is the difference between the committed lock file and the registry. Merging it restores that difference within hours, so the next job inside the window has something to create again. Across 2026-08-27 to 08-29 that produced seven pull requests across the two repositories that carry lock files, one of them opened thirty-six seconds after its predecessor merged, each carrying a single transitive package where one weekly pull request would have carried all of them. Five hours still exceeds the four-hour job interval, so this window cannot fall between two jobs the way the Sunday evening one did. Nothing urgent rides on the cadence either: osvVulnerabilityAlerts in the default preset bypasses every schedule, which leaves lock file maintenance a routine refresh rather than the security net." |
There was a problem hiding this comment.
✨ [POSITIVE] 修正内容は正確で、PRの説明にある表と一致しています。over three repositories を across the two repositories that carry lock files に変更することで、観測対象がロックファイルを持つリポジトリに限定されることが明示され、直前の段落の no-op for repositories that have no lock file との整合性も取れています。良い改善です。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#158 で
latex.jsonの description に書いた観測値が誤っていたので直します。1 行です。何を間違えたか
.githubの 2 本を lock file maintenance として数えていました。このリポジトリにpackage-lock.jsonはありません。 lockfile が無いので lock file maintenance は起きえず、直前の段落自身がit is a no-op for repositories that have no lock fileと書いています。実体は #154 / #156（
smkwlab/ai-academic-paper-revieweraction を v1.20 / v1.22 に更新）で、本文の Release Notes に "lock file maintenance" の文字列が含まれていたものです。gh search prs --owner smkwlab "lock file maintenance"は全文検索なので、タイトルではなく本文にマッチしていました。結論は変わりません
7 本でも同じ問題です。決定的証拠だった「ai-academic-paper-reviewer #77 が #76 のマージ 36 秒後に作成された」も無傷ですし、窓を狭める根拠も、
before 5am on fridayという値も変わりません。訂正するのは数字だけです。書き方も少し変えています
over three repositoriesをacross the two repositories that carry lock filesにしました。単に数を直すだけでなく、この観測が lockfile を持つリポジトリに限られることを明示しておけば、次に数える人が同じ間違い方をしません。直前の段落のno-op for repositories that have no lock fileとも整合します。関連
.githubの行を落とす必要があるため、あちらにも訂正コメントを入れますv1の再移動が必要です