Skip to content

Remove Suspense when freeze false #30

Description

@xotahal

More of a question than an issue I would say. Why do we need Suspense here https://github.com/software-mansion/react-freeze/blob/main/src/index.tsx#L39?

The react-freeze is used by react-navigation. I don't use the freeze option but my screens go to suspense in this library and render null. I believe there would be a way to propagate placeholder and display something, but I already have suspense in my app. I want that suspense to catch the promise.

I can submit a PR with something like this:

if (!freeze) {
  return <Fragment>{props.children}</Fragment>
}

I just wanted to validate first

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions