fix: null-safe infinite query pages access - #182
Merged
Merged
Conversation
Prevent render crashes when cache data is truthy but missing the
`{ pages, pageParams }` wrapper (e.g. RQ v4 hydrate + observer-less refetch).
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: a470fff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data.pagesin@soundxyz/graphql-react-query'suseInfiniteQuery(firstPage,lastPage,orderedListreduce) so a malformed infinite-query cache entry no longer throws during render (TypeError: … evaluating 'w?.pages[0]').5.5.3release.Context
Seen in Vault RUM on
/chats(Capacitor iOS): RQ v4 can leave a truthy non-{pages,pageParams}value in an Infinite key after hydrate + observer-lessinvalidateQueries/refetchQueries. The wrapper only optional-chaineddata, notpages, which took down the React tree via the top-level error boundary.Test plan
5.5.3via changeset release5.5.3and confirms the RUM fingerprint stops (or degrades to empty inbox rather than fatal crash)Made with Cursor