rename: fix Turnstile comment + dangling doc ref - #4
Merged
Conversation
Two issues caught by the adversarial rename-verification pass: - wrangler.jsonc: the TURNSTILE_SITE_KEY comment implied an nbread.lol widget exists; the key is actually carried over from the old nostrbook.net widget and fails the nbread.lol hostname check until re-provisioned. Reworded to say so (agrees with docs/setup.md §6). - docs/setup.md: dropped a dangling '(see the rename plan, Phase 5)' reference (no such doc in-repo; 'Phase 5' collided with the unrelated docs/phases/P5.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small correctness fixes caught by the adversarial rename-verification pass on #3:
TURNSTILE_SITE_KEYcomment implied annbread.lolwidget exists. The key is carried over from the old nostrbook.net widget and will fail thenbread.lolhostname check until re-provisioned — reworded to say so (now agrees withdocs/setup.md§6). Prevents a deployment footgun.docs/phases/P5.md.Comment/doc only; no code or test changes.
wrangler deploy --dry-runOK.