Skip to content

Switch from fixed packet size to varint #1

Description

@mdwaud

Currently Sink uses packet_size: 2 since Erlang handles the encoding/decoding for us. This limits us to a maximum message size of 2^16 bytes, though, which is can be small for transmitting snapshots, large batch publishes, or NACK responses to batch publish. Also, for small publish messages it wastes a byte. Switching to a varint adds some complexity, but solves both cases.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions