ci: build MSIX on test builds so the packaging path is validated - #93
Merged
Conversation
- Remove the dev/test skip in build-windows.yml's MSIX step: every branch/PR build now builds OpenReader-test.msix (attached to the workflow artifact, never published), so a broken MSIX packaging path surfaces in CI instead of only at release time. Missing MakeAppx.exe remains the only valid skip. Co-Authored-By: Claude <noreply@anthropic.com>
Deploying reader with
|
| Latest commit: |
23d3716
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf76411d.reader-bsl.pages.dev |
| Branch Preview URL: | https://fix-ci-msix-test-builds.reader-bsl.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-windows.ymlskipped the MSIX step for*-test/dev versions, so the MSIX packaging path was never exercised by CI — it only broke at release time (the v1.2.7 MSIX-icon incident). This removes the version-based skip: every branch/PR build now buildsOpenReader-test.msixand attaches it to thebuild-windowsartifact (never published). MissingMakeAppx.exeremains the only valid skip.Co-Authored-By: Claude noreply@anthropic.com