Skip to content

fix(csr-common): export form field re-edit metric key - #467

Merged
sam-cook merged 1 commit into
mainfrom
codex/add-form-field-re-edit-metric-key
Sep 17, 2026
Merged

sam-cook merged 1 commit into
mainfrom
codex/add-form-field-re-edit-metric-key

Conversation

@sam-cook

@sam-cook sam-cook commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Hi There, I just made a Pull Request!

Adds the missing RecordingMetricKey.FormFieldReEdit aggregate metric identifier and classifies it as a user-interaction metric. This aligns the metric contract with the existing RecordingCustomEventTag.FormFieldReEdit event contract.

✔️ Checklist

  • All tests are passing
  • Relevant documentation updated — no documentation change needed
  • linter/style run on changed files
  • Tests added for new functionality
  • Regression tests added for bug fixes
  • Tested in a corresponding example app — no example-app behavior changed

Validation

  • yarn format:check
  • yarn test:csr — 17 files, 231 tests
  • yarn build:csr
  • yarn tsc --noEmit -p csr/csr-common/tsconfig.json
  • yarn tsc --noEmit -p csr/csr-recorder/tsconfig.json
  • yarn tsc --noEmit -p csr/session-recording/tsconfig.json
  • isolated-worktree equivalent of yarn lint:csr

Generated with Codex.

Co-authored-by: Codex <noreply@openai.com>
@sam-cook
sam-cook merged commit 37a4dff into main Sep 17, 2026
4 checks passed
@sam-cook
sam-cook deleted the codex/add-form-field-re-edit-metric-key branch September 17, 2026 14:22
@github-actions github-actions Bot mentioned this pull request Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants