Support Symfony 7. - #25
Open
vol4onok wants to merge 9 commits into
Open
Conversation
1 task
…com/spryker-sdk/async-api into feature/frw-11816/master-support-sf-7-4
…odern Rector config API, fix real PHPStan errors, and apply Rector's own auto-fixes - spryker-sdk/architector: 0.1.x-dev -> dev-feature/frw-11816/symfony-7-support (temporary, for testing; revert once the architector PR is merged) - phpstan.neon: remove obsolete checkMissingIterableValueType option (Rector 2.x pulls in phpstan/phpstan 2.x transitively), restore equivalent leniency via ignoreErrors since the missing array value types are pre-existing and out of scope here - fix 2 real errors phpstan 2.x now catches: error_get_last()/getenv() called twice assuming the same narrowed result across both calls - architector.php: RectorConfig::parameters()->set(Option::SKIP, ...) removed in Rector 2.x, replaced with skip(); 4 skipped rule classes no longer exist and were dropped, SimplifyUselessVariableRector's namespace changed - ran composer rector to apply the now-passing dead-code/php74 rule sets: 11 files with redundant @return docblocks (duplicating the native return type) and 2 properties with redundant/unsafe '= null' defaults - reverted one of those two: AbstractAsyncApiMessage::$isWindows is a *static* property only assigned in the instance constructor, so removing its default broke real usage (Typed static property must not be accessed before initialization) even though Rector's static analysis considered it safe; caught by running the actual test suite, not just static analysis
…tractAsyncApiMessage::$isWindows Path-scoped skip so future 'composer rector' runs don't keep re-proposing this incorrect transform (it's a static property only assigned in the instance constructor, so Rector's constructor-assignment safety check doesn't hold for it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer(s):
Ticket: https://spryker.atlassian.net/browse/FRW-11817
Improvements