Document dependsOn/scope for dependent import steps in build-plugin skill#97
Conversation
📝 WalkthroughWalkthroughThe build-plugin guidance now covers scoped dependent imports, including planning, dependency-level testing, Checkpoint B reruns, and reconciliation. The index-definition reference adds an optional ChangesDependent import workflow
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/build-plugin/references/index-defs.md:
- Around line 37-48: Update the scope.query in the installations import
definition to constrain results to device vertices, using the device-specific
discriminator/property rather than only sourceType = "Router"; preserve the
existing objectMapping, optional flag, and dependsOn configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 40883316-d1c6-4de9-8b56-6b727da87d65
📒 Files selected for processing (2)
.claude/skills/build-plugin/SKILL.md.claude/skills/build-plugin/references/index-defs.md
🧩 Plugin PR Summaryℹ️ No plugins were modified in this PR. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/build-plugin/SKILL.md:
- Around line 255-258: Expand the dependent-stream testing procedure in the
build-plugin skill to cover both scoped stream types: retain single-object
testing with --object for httpRequestScopedSingle, and add instructions for
httpRequestScoped streams to test the complete matched-object set and verify
{{objects}} is populated correctly. Reference the existing scoped test procedure
and index-definitions guidance without changing the dependency-level workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1395480d-e210-4804-ba96-145ae4d09c32
📒 Files selected for processing (2)
.claude/skills/build-plugin/SKILL.md.claude/skills/build-plugin/references/index-defs.md
📋 Summary
Adds guidance to the
build-pluginskill on usingdependsOn+scopeonindexDefinitionssteps, so an import step can wait for another step's objects to land and scope its dataStream query to them (seeplugins/Sanity/v1/indexDefinitions/default.jsonfor a real example).references/index-defs.md— extends the existing worked example with a dependent step and documentsscope.query,dependsOn(including multi-dependency and multi-level chains), andoptional.SKILL.md— Phase 2 now flags when to plan a dependent step; Phase 5 adds a conditional "one pass per dependency level" build/test loop, reusing the existing scoped-stream test procedure and Checkpoint B re-index cycle rather than introducing new mechanics.🔍 Scope of change
📚 Checklist
Summary by CodeRabbit
deviceAlertsimport example and documentedoptionalbehavior (warnings instead of hard failures).