Skip to content

chore(serviceenablement): switch to new sdk structure#1487

Merged
rubenhoenle merged 1 commit into
mainfrom
chore/sdk-migration-serviceenablement
Jul 22, 2026
Merged

chore(serviceenablement): switch to new sdk structure#1487
rubenhoenle merged 1 commit into
mainfrom
chore/sdk-migration-serviceenablement

Conversation

@rubenhoenle

Copy link
Copy Markdown
Member

Description

relates to STACKITCLI-354

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
rubenhoenle requested a review from a team as a code owner July 21, 2026 10:41
@rubenhoenle
rubenhoenle force-pushed the chore/sdk-migration-serviceenablement branch from 5817a8e to 107e628 Compare July 22, 2026 09:00
@rubenhoenle
rubenhoenle enabled auto-merge (squash) July 22, 2026 10:05
@rubenhoenle
rubenhoenle force-pushed the chore/sdk-migration-serviceenablement branch from 107e628 to e335472 Compare July 22, 2026 10:05
@rubenhoenle
rubenhoenle merged commit 1e4db53 into main Jul 22, 2026
3 checks passed
@rubenhoenle
rubenhoenle deleted the chore/sdk-migration-serviceenablement branch July 22, 2026 10:09
@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/create 37.84% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list 51.52% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/describe 58.82% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/disable 25.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/enable 25.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-enablement/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-enablement/utils 88.89% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/client 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/create/create.go 37.84% (ø) 74 28 46
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list/list.go 51.52% (ø) 66 34 32
github.com/stackitcloud/stackit-cli/internal/cmd/ske/describe/describe.go 58.82% (ø) 34 20 14
github.com/stackitcloud/stackit-cli/internal/cmd/ske/disable/disable.go 25.00% (ø) 40 10 30
github.com/stackitcloud/stackit-cli/internal/cmd/ske/enable/enable.go 25.00% (ø) 40 10 30
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-enablement/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-enablement/utils/utils.go 88.89% (ø) 9 8 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/ske/client/client.go 0.00% (ø) 1 0 1

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/disable/disable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/enable/enable_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/service-enablement/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants