Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ require (
github.com/spf13/viper v1.21.0
github.com/stackitcloud/stackit-sdk-go/core v0.26.0
github.com/stackitcloud/stackit-sdk-go/services/alb v0.14.2
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.12.0
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.15.2
github.com/stackitcloud/stackit-sdk-go/services/cdn v1.16.0
github.com/stackitcloud/stackit-sdk-go/services/dns v0.21.0
github.com/stackitcloud/stackit-sdk-go/services/edge v0.4.3
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -594,8 +594,8 @@ github.com/stackitcloud/stackit-sdk-go/core v0.26.0 h1:jQEb9gkehfp6VCP6TcYk7BI10
github.com/stackitcloud/stackit-sdk-go/core v0.26.0/go.mod h1:WU1hhxnjXw2EV7CYa1nlEvNpMiRY6CvmIOaHuL3pOaA=
github.com/stackitcloud/stackit-sdk-go/services/alb v0.14.2 h1:hGzfOJjlCRoFpri5eYIiwhE27qu02pKZLprKvbsTC/w=
github.com/stackitcloud/stackit-sdk-go/services/alb v0.14.2/go.mod h1:eK6oRB5Tmpt6KbXQ4UYBGg2LgW5bPtVoncL9E8JSRww=
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.12.0 h1:HxPgBu04j5tj6nfZ2r0l6v4VXC0/tYOGe4sA5Addra8=
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.12.0/go.mod h1:uYI9pHAA2g84jJN25ejFUxa0/JtfpPZqMDkctQ1BzJk=
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.15.2 h1:b7WJ/vwxlVmNNX91kI3obqGcuoPAyaCbDL5aCMQ/sNg=
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.15.2/go.mod h1:T/JF25XGJ3GqER/1L2N//DgY8x5tY7gA3N+/0nvmOWY=
github.com/stackitcloud/stackit-sdk-go/services/cdn v1.16.0 h1:Wqxx0PDTL2F5gqI5jjznuJY0TdqECltjA0aa/rHY63U=
github.com/stackitcloud/stackit-sdk-go/services/cdn v1.16.0/go.mod h1:MHB1N3EQ9GuAduAQoNS+gb1MjrWJieszbpOso9TQv5s=
github.com/stackitcloud/stackit-sdk-go/services/dns v0.21.0 h1:ZVkptfVCAqpaPWkE+WIopM9XdzqgbVcwmX5L1jZqqx8=
Expand Down
23 changes: 11 additions & 12 deletions internal/cmd/organization/member/add/add.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ import (
"github.com/stackitcloud/stackit-cli/internal/pkg/types"

"github.com/spf13/cobra"
"github.com/stackitcloud/stackit-sdk-go/services/authorization"
authorization "github.com/stackitcloud/stackit-sdk-go/services/authorization/v2api"

"github.com/stackitcloud/stackit-cli/internal/pkg/args"
"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
"github.com/stackitcloud/stackit-cli/internal/pkg/print"
"github.com/stackitcloud/stackit-cli/internal/pkg/services/authorization/client"
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
)

const (
Expand All @@ -30,9 +29,9 @@ const (
type inputModel struct {
*globalflags.GlobalFlagModel

OrganizationId *string
OrganizationId string
Subject string
Role *string
Role string
}

func NewCmd(params *types.CmdParams) *cobra.Command {
Expand All @@ -59,7 +58,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
return err
}

prompt := fmt.Sprintf("Are you sure you want to add the %s role to %s on organization with ID %q?", *model.Role, model.Subject, *model.OrganizationId)
prompt := fmt.Sprintf("Are you sure you want to add the %s role to %s on organization with ID %q?", model.Role, model.Subject, model.OrganizationId)
err = params.Printer.PromptForConfirmation(prompt)
if err != nil {
return err
Expand Down Expand Up @@ -101,25 +100,25 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu

model := inputModel{
GlobalFlagModel: globalFlags,
OrganizationId: flags.FlagToStringPointer(p, cmd, organizationIdFlag),
OrganizationId: flags.FlagToStringValue(p, cmd, organizationIdFlag),
Subject: subject,
Role: flags.FlagToStringPointer(p, cmd, roleFlag),
Role: flags.FlagToStringValue(p, cmd, roleFlag),
}

p.DebugInputModel(model)
return &model, nil
}

func buildRequest(ctx context.Context, model *inputModel, apiClient *authorization.APIClient) authorization.ApiAddMembersRequest {
req := apiClient.AddMembers(ctx, *model.OrganizationId)
req := apiClient.DefaultAPI.AddMembers(ctx, model.OrganizationId)
req = req.AddMembersPayload(authorization.AddMembersPayload{
Members: utils.Ptr([]authorization.Member{
Members: []authorization.Member{
{
Subject: utils.Ptr(model.Subject),
Subject: model.Subject,
Role: model.Role,
},
}),
ResourceType: utils.Ptr(organizationResourceType),
},
ResourceType: organizationResourceType,
})
return req
}
29 changes: 14 additions & 15 deletions internal/cmd/organization/member/add/add_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,18 @@ import (
"context"
"testing"

"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"

"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/stackitcloud/stackit-sdk-go/services/authorization"
authorization "github.com/stackitcloud/stackit-sdk-go/services/authorization/v2api"

"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
)

type testCtxKey struct{}

var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &authorization.APIClient{}
var testClient = &authorization.APIClient{DefaultAPI: &authorization.DefaultAPIService{}}
var testOrganizationID = "some-organization-id"
var testSubject = "someone@domain.com"
var testRole = "reader"
Expand Down Expand Up @@ -45,9 +44,9 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
model := &inputModel{
GlobalFlagModel: &globalflags.GlobalFlagModel{Verbosity: globalflags.VerbosityDefault},
OrganizationId: utils.Ptr(testOrganizationID),
OrganizationId: testOrganizationID,
Subject: testSubject,
Role: utils.Ptr(testRole),
Role: testRole,
}
for _, mod := range mods {
mod(model)
Expand All @@ -56,15 +55,15 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
}

func fixtureRequest(mods ...func(request *authorization.ApiAddMembersRequest)) authorization.ApiAddMembersRequest {
request := testClient.AddMembers(testCtx, testOrganizationID)
request := testClient.DefaultAPI.AddMembers(testCtx, testOrganizationID)
request = request.AddMembersPayload(authorization.AddMembersPayload{
Members: utils.Ptr([]authorization.Member{
Members: []authorization.Member{
{
Subject: &testSubject,
Role: &testRole,
Subject: testSubject,
Role: testRole,
},
}),
ResourceType: utils.Ptr(organizationResourceType),
},
ResourceType: organizationResourceType,
})

for _, mod := range mods {
Expand Down Expand Up @@ -148,7 +147,7 @@ func TestBuildRequest(t *testing.T) {

diff := cmp.Diff(request, tt.expectedRequest,
cmp.AllowUnexported(tt.expectedRequest),
cmpopts.EquateComparable(testCtx),
cmpopts.EquateComparable(testCtx, authorization.DefaultAPIService{}),
)
if diff != "" {
t.Fatalf("Data does not match: %s", diff)
Expand Down
30 changes: 15 additions & 15 deletions internal/cmd/organization/member/list/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"github.com/stackitcloud/stackit-cli/internal/pkg/types"

"github.com/spf13/cobra"
"github.com/stackitcloud/stackit-sdk-go/services/authorization"
authorization "github.com/stackitcloud/stackit-sdk-go/services/authorization/v2api"

"github.com/stackitcloud/stackit-cli/internal/pkg/args"
"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
Expand All @@ -18,7 +18,6 @@ import (
"github.com/stackitcloud/stackit-cli/internal/pkg/print"
"github.com/stackitcloud/stackit-cli/internal/pkg/services/authorization/client"
"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
)

const (
Expand All @@ -39,7 +38,7 @@ var sortByFlag = flags.StringEnumFlag(
type inputModel struct {
*globalflags.GlobalFlagModel

OrganizationId *string
OrganizationId string
Subject *string
Limit *int64
SortBy string
Expand Down Expand Up @@ -81,18 +80,14 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
if err != nil {
return fmt.Errorf("list members: %w", err)
}
members := *resp.Members
if len(members) == 0 {
params.Printer.Info("No members found for organization with ID %q\n", *model.OrganizationId)
return nil
}
members := resp.Members

// Truncate output
if model.Limit != nil && len(members) > int(*model.Limit) {
members = members[:*model.Limit]
}

return outputResult(params.Printer, model.OutputFormat, model.SortBy, members)
return outputResult(params.Printer, model.OutputFormat, model.OrganizationId, model.SortBy, members)
},
}
configureFlags(cmd)
Expand Down Expand Up @@ -122,7 +117,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,

model := inputModel{
GlobalFlagModel: globalFlags,
OrganizationId: flags.FlagToStringPointer(p, cmd, organizationIdFlag),
OrganizationId: flags.FlagToStringValue(p, cmd, organizationIdFlag),
Subject: flags.FlagToStringPointer(p, cmd, subjectFlag),
Limit: flags.FlagToInt64Pointer(p, cmd, limitFlag),
SortBy: sortByFlag.Get(),
Expand All @@ -133,27 +128,32 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
}

func buildRequest(ctx context.Context, model *inputModel, apiClient *authorization.APIClient) authorization.ApiListMembersRequest {
req := apiClient.ListMembers(ctx, organizationResourceType, *model.OrganizationId)
req := apiClient.DefaultAPI.ListMembers(ctx, organizationResourceType, model.OrganizationId)
if model.Subject != nil {
req = req.Subject(*model.Subject)
}
return req
}

func outputResult(p *print.Printer, outputFormat, sortBy string, members []authorization.Member) error {
func outputResult(p *print.Printer, outputFormat, organizationId, sortBy string, members []authorization.Member) error {
sortFn := func(i, j int) bool {
switch sortBy {
case "subject":
return *members[i].Subject < *members[j].Subject
return members[i].Subject < members[j].Subject
case "role":
return *members[i].Role < *members[j].Role
return members[i].Role < members[j].Role
default:
return false
}
}
sort.SliceStable(members, sortFn)

return p.OutputResult(outputFormat, members, func() error {
if len(members) == 0 {
p.Outputf("No members found for organization with ID %q\n", organizationId)
return nil
}

table := tables.NewTable()
table.SetHeader("SUBJECT", "ROLE")
for i := range members {
Expand All @@ -162,7 +162,7 @@ func outputResult(p *print.Printer, outputFormat, sortBy string, members []autho
if i > 0 && sortFn(i-1, i) {
table.AddSeparator()
}
table.AddRow(utils.PtrString(m.Subject), utils.PtrString(m.Role))
table.AddRow(m.Subject, m.Role)
}

switch sortBy {
Expand Down
19 changes: 10 additions & 9 deletions internal/cmd/organization/member/list/list_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ import (

"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/stackitcloud/stackit-sdk-go/services/authorization"
authorization "github.com/stackitcloud/stackit-sdk-go/services/authorization/v2api"
)

type testCtxKey struct{}

var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &authorization.APIClient{}
var testClient = &authorization.APIClient{DefaultAPI: &authorization.DefaultAPIService{}}
var testOrganizationID = "some-organization-id"

func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
Expand All @@ -34,7 +34,7 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
model := &inputModel{
GlobalFlagModel: &globalflags.GlobalFlagModel{Verbosity: globalflags.VerbosityDefault},
OrganizationId: utils.Ptr(testOrganizationID),
OrganizationId: testOrganizationID,
Limit: utils.Ptr(int64(10)),
SortBy: "subject",
}
Expand All @@ -45,7 +45,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
}

func fixtureRequest(mods ...func(request *authorization.ApiListMembersRequest)) authorization.ApiListMembersRequest {
request := testClient.ListMembers(testCtx, organizationResourceType, testOrganizationID)
request := testClient.DefaultAPI.ListMembers(testCtx, organizationResourceType, testOrganizationID)
for _, mod := range mods {
mod(&request)
}
Expand Down Expand Up @@ -156,7 +156,7 @@ func TestBuildRequest(t *testing.T) {

diff := cmp.Diff(request, tt.expectedRequest,
cmp.AllowUnexported(tt.expectedRequest),
cmpopts.EquateComparable(testCtx),
cmpopts.EquateComparable(testCtx, authorization.DefaultAPIService{}),
)
if diff != "" {
t.Fatalf("Data does not match: %s", diff)
Expand All @@ -167,9 +167,10 @@ func TestBuildRequest(t *testing.T) {

func TestOutputResult(t *testing.T) {
type args struct {
outputFormat string
sortBy string
members []authorization.Member
outputFormat string
organizationId string
sortBy string
members []authorization.Member
}
tests := []struct {
name string
Expand Down Expand Up @@ -199,7 +200,7 @@ func TestOutputResult(t *testing.T) {
params := testparams.NewTestParams()
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if err := outputResult(params.Printer, tt.args.outputFormat, tt.args.sortBy, tt.args.members); (err != nil) != tt.wantErr {
if err := outputResult(params.Printer, tt.args.outputFormat, tt.args.organizationId, tt.args.sortBy, tt.args.members); (err != nil) != tt.wantErr {
t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
}
})
Expand Down
Loading
Loading