Skip to content

chore(serviceaccount): migrate to new sdk structure#1489

Open
rubenhoenle wants to merge 1 commit into
mainfrom
chore/sdk-migration-serviceaccount
Open

chore(serviceaccount): migrate to new sdk structure#1489
rubenhoenle wants to merge 1 commit into
mainfrom
chore/sdk-migration-serviceaccount

Conversation

@rubenhoenle

Copy link
Copy Markdown
Member

Description

relates to STACKITCLI-354

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
rubenhoenle requested a review from a team as a code owner July 21, 2026 11:50
@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 3 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/create 50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/delete 36.67% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/get-jwks 41.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/create 50.94% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/delete 48.57% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/describe 62.16% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/list 65.38% (+5.77%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/update 63.93% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/list 57.45% (+6.38%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/create 60.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/list 65.31% (+6.12%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/revoke 48.57% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/flags 62.31% (-0.96%) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-account/client 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/create/create.go 50.00% (ø) 40 20 20
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/delete/delete.go 36.67% (ø) 30 11 19
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/get-jwks/get_jwks.go 41.38% (ø) 29 12 17
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/create/create.go 50.94% (ø) 53 27 26
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/delete/delete.go 48.57% (ø) 35 17 18
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/describe/describe.go 62.16% (ø) 37 23 14
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/list/list.go 65.38% (+5.77%) 52 34 (+3) 18 (-3) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/update/update.go 63.93% (ø) 61 39 22
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/list/list.go 57.45% (+6.38%) 47 27 (+3) 20 (-3) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/create/create.go 60.00% (ø) 45 27 18
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/list/list.go 65.31% (+6.12%) 49 32 (+3) 17 (-3) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/revoke/revoke.go 48.57% (ø) 35 17 18
github.com/stackitcloud/stackit-cli/internal/pkg/flags/flag_to_value.go 20.87% (-0.95%) 115 (+5) 24 91 (+5) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/services/service-account/client/client.go 0.00% (ø) 1 0 1

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/get-jwks/get_jwks_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/key/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/service-account/token/revoke/revoke_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants