STACKITRCO-187 - Add option iaas API param agent#1113
Merged
rubenhoenle merged 1 commit intoMay 12, 2026
Merged
Conversation
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
2 times, most recently
from
January 9, 2026 07:06
44c1522 to
699af50
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
cgoetz-inovex
previously requested changes
Jan 19, 2026
cgoetz-inovex
left a comment
Contributor
There was a problem hiding this comment.
lgtm besides the docs
rubenhoenle
reviewed
Jan 19, 2026
rubenhoenle
reviewed
Jan 19, 2026
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
January 21, 2026 11:51
d208dba to
91a621b
Compare
rubenhoenle
marked this pull request as draft
April 14, 2026 08:40
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
April 20, 2026 05:23
91a621b to
7c34d59
Compare
aeter
pushed a commit
to aeter/terraform-provider-stackit
that referenced
this pull request
Apr 20, 2026
Adds a terraform `stackit_server` option for the iaas ( _create server_ ) API param:
`"agent": {"provisioned": true}`
ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
review url: stackitcloud#1113
---
Tests:
* ran `make fmt`, `make generate-docs`, `make lint`
* ran unit tests
```
[~/terraform-provider-stackit] go test stackit/internal/services/iaas/server/*
ok command-line-arguments 15.005s
[~/terraform-provider-stackit] make test
...
ok github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 15.006s coverage: 33.0% of statements
...
[~/terraform-provider-stackit]
```
* Tested: with a locally-configured terraform, by adding, changing, deleting `agent`-related parts of a tf config.
Signed-off-by: Adrian Nackov <adrian.nackov@digits.schwarz>
Contributor
Author
|
please review. I've updated the code as requested - added acceptance testsA server created without sending 'provisioning' flag via the CLI - and then imported into terraform:A server created in terraform with defaults (no 'agent' block):A server created in terraform like this. Note the ALWAYS->INHERIT in datasource, which can/should be fixed when the API is fixed one day: |
7 tasks
aeter
marked this pull request as ready for review
April 20, 2026 05:35
rubenhoenle
reviewed
Apr 20, 2026
aeter
pushed a commit
to aeter/terraform-provider-stackit
that referenced
this pull request
Apr 20, 2026
Adds a terraform `stackit_server` option for the iaas ( _create server_ ) API param:
`"agent": {"provisioned": true}`
ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
review url: stackitcloud#1113
---
Tests:
* ran `make fmt`, `make generate-docs`, `make lint`
* ran unit tests
```
[~/terraform-provider-stackit] go test stackit/internal/services/iaas/server/*
ok command-line-arguments 15.005s
[~/terraform-provider-stackit] make test
...
ok github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 15.006s coverage: 33.0% of statements
...
[~/terraform-provider-stackit]
```
* Tested: with a locally-configured terraform, by adding, changing, deleting `agent`-related parts of a tf config.
Signed-off-by: Adrian Nackov <adrian.nackov@digits.schwarz>
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
April 20, 2026 10:04
7c34d59 to
8942b1e
Compare
rubenhoenle
reviewed
Apr 20, 2026
aeter
pushed a commit
to aeter/terraform-provider-stackit
that referenced
this pull request
Apr 20, 2026
Adds a terraform `stackit_server` option for the iaas ( _create server_ ) API param:
`"agent": {"provisioned": true}`
ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
review url: stackitcloud#1113
---
Tests:
* ran `make fmt`, `make generate-docs`, `make lint`
* ran unit tests
```
[~/terraform-provider-stackit] go test stackit/internal/services/iaas/server/*
ok command-line-arguments 15.005s
[~/terraform-provider-stackit] make test
...
ok github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 15.006s coverage: 33.0% of statements
...
[~/terraform-provider-stackit]
```
* Tested: with a locally-configured terraform, by adding, changing, deleting `agent`-related parts of a tf config.
Signed-off-by: Adrian Nackov <adrian.nackov@digits.schwarz>
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
April 20, 2026 17:33
8942b1e to
be8d15a
Compare
Contributor
Author
|
updated per review |
rubenhoenle
reviewed
Apr 30, 2026
aeter
pushed a commit
to aeter/terraform-provider-stackit
that referenced
this pull request
Apr 30, 2026
Adds a terraform `stackit_server` option for the iaas ( _create server_ ) API param:
`"agent": {"provisioned": true}`
ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
review url: stackitcloud#1113
---
Tests:
* ran `make fmt`, `make generate-docs`, `make lint`
* ran unit tests
```
[~/terraform-provider-stackit] go test stackit/internal/services/iaas/server/*
ok command-line-arguments 15.005s
[~/terraform-provider-stackit] make test
...
ok github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 15.006s coverage: 33.0% of statements
...
[~/terraform-provider-stackit]
```
* Tested: with a locally-configured terraform, by adding, changing, deleting `agent`-related parts of a tf config.
Signed-off-by: Adrian Nackov <adrian.nackov@digits.schwarz>
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
April 30, 2026 10:03
be8d15a to
b7e25e0
Compare
aeter
pushed a commit
to aeter/terraform-provider-stackit
that referenced
this pull request
May 8, 2026
Adds a terraform `stackit_server` option for the iaas ( _create server_ ) API param:
`"agent": {"provisioned": true}`
ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
review url: stackitcloud#1113
---
Tests:
* ran `make fmt`, `make generate-docs`, `make lint`
* ran unit tests
```
[~/terraform-provider-stackit] go test stackit/internal/services/iaas/server/*
ok command-line-arguments 15.005s
[~/terraform-provider-stackit] make test
...
ok github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 15.006s coverage: 33.0% of statements
...
[~/terraform-provider-stackit]
```
* Tested: with a locally-configured terraform, by adding, changing, deleting `agent`-related parts of a tf config.
Signed-off-by: Adrian Nackov <adrian.nackov@digits.schwarz>
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
May 8, 2026 11:08
b7e25e0 to
2f00be9
Compare
rubenhoenle
previously approved these changes
May 8, 2026
Manuelvaas
requested changes
May 11, 2026
aeter
pushed a commit
to aeter/terraform-provider-stackit
that referenced
this pull request
May 11, 2026
Adds a terraform `stackit_server` option for the iaas ( _create server_ ) API param:
`"agent": {"provisioned": true}`
ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
review url: stackitcloud#1113
---
Tests:
* ran `make fmt`, `make generate-docs`, `make lint`
* ran unit tests
```
[~/terraform-provider-stackit] go test stackit/internal/services/iaas/server/*
ok command-line-arguments 15.005s
[~/terraform-provider-stackit] make test
...
ok github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 15.006s coverage: 33.0% of statements
...
[~/terraform-provider-stackit]
```
* Tested: with a locally-configured terraform, by adding, changing, deleting `agent`-related parts of a tf config.
Signed-off-by: Adrian Nackov <adrian.nackov@digits.schwarz>
aeter
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
May 11, 2026 16:35
2f00be9 to
9e13641
Compare
rubenhoenle
approved these changes
May 12, 2026
Adds a terraform `stackit_server` option for the iaas ( _create server_ ) API param:
`"agent": {"provisioned": true}`
ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
review url: stackitcloud#1113
---
Tests:
* ran `make fmt`, `make generate-docs`, `make lint`
* ran unit tests
```
[~/terraform-provider-stackit] go test stackit/internal/services/iaas/server/*
ok command-line-arguments 15.005s
[~/terraform-provider-stackit] make test
...
ok github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 15.006s coverage: 33.0% of statements
...
[~/terraform-provider-stackit]
```
* Tested: with a locally-configured terraform, by adding, changing, deleting `agent`-related parts of a tf config.
Signed-off-by: Adrian Nackov <adrian.nackov@digits.schwarz>
rubenhoenle
force-pushed
the
feature/STACKITRCO-187-iaas-create-server-agent-param
branch
from
May 12, 2026 08:15
9e13641 to
b12cfb9
Compare
rubenhoenle
enabled auto-merge (squash)
May 12, 2026 08:16
Manuelvaas
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a terraform
stackit_serveroption for the iaas ( create server ) API param:"agent": {"provisioned": true}ref STACKITRCO-187
ref: stackitcloud/stackit-cli#1213
Tests:
* ran
make fmt,make generate-docs,make lintDescription
relates to STACKITRCO-187
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)